[Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

Neil Roberts neil at linux.intel.com
Tue Jul 1 10:09:04 PDT 2014


Jason Ekstrand <jason at jlekstrand.net> writes:

>> +   texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj->Target,
>> level);
>>
>
> Do you want this inside an else block?

I think it's quite a common idiom in Mesa to handle the special cases as
a series of if-statements with a return upfront before handling the
normal case at the end without an else. But yes, in this instance it
does look a bit odd because the there is only one special case and the
normal case is very short, so I don't mind changing it.

Regards,
- Neil


More information about the mesa-dev mailing list