[Mesa-dev] [PATCH 11/16] glsl: Track matrix layout of structure fields using two bits

Matt Turner mattst88 at gmail.com
Mon Jul 21 15:17:05 PDT 2014


On Mon, Jul 21, 2014 at 2:04 PM, Ian Romanick <idr at freedesktop.org> wrote:
> +enum glsl_matrix_layout {
> +   GLSL_MATRIX_LAYOUT_DEFAULT,

Does this mean language-default, or does it really means the inherited
layout? E.g., for

layout(row_major) uniform a {
   mat4 m;
};

m's .matrix_layout is GLSL_MATRIX_LAYOUT_DEFAULT, so we look to the
outer row_major qualifier on uniform a?

If so, could we name it _INHERITED or something?

Maybe I've misunderstood.

> +   GLSL_MATRIX_LAYOUT_COLUMN_MAJOR,
> +   GLSL_MATRIX_LAYOUT_ROW_MAJOR
> +};


More information about the mesa-dev mailing list