[Mesa-dev] [PATCH v2 0/5] Fix handling of LnAn and RnGn formats for big-endian

Brian Paul brianp at vmware.com
Mon Jul 28 09:39:34 PDT 2014


On 07/22/2014 03:51 AM, Richard Sandiford wrote:
>> MESA_FORMAT_LnAn_* puts the luminance in the low part of the integer and
>> the alpha in the high part.  The same goes for MESA_FORMAT_RnGn with the
>> red and green channels.
>>
>> This series fixes gallium to be consistent with that layout on big-endian.
>> Following the convention established last year, PIPE_FORMAT_LAnn and
>> PIPE_FORMAT_RGnn are the equivalent gallium formats.  Where defined,
>> PIPE_FORMAT_LnAn puts the luminance first in memory and the alpha
>> last in memory.
>>
>> Patch 1 also fixes an endianness bug in mesa swrast for MESA_FORMAT_L8A8_SRGB.
>> AFAICT all other L/A and R/G formats are handled correctly.
>
> v2, with subject lines fixed to include the "component:" bit.  No code changes
> from v1.
>
> Richard Sandiford (5):
>    swrast: Fix handling of MESA_FORMAT_L8A8_SRGB for big-endian
>    util: Add PIPE_FORMAT_AnLn and PIPE_FORMAT_GnRn formats
>    util: Define PIPE_FORMAT_{LA,AL,RG,GR}nn aliases
>    mesa: Add MESA_FORMAT_A8L8_{SNORM,SRGB}
>    st/mesa: Fix handling of LA and RG formats for big-endian
>

This series looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list