[Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

[Ian Romanick]

On 06/06/2014 05:13 PM, Carl Worth wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>> Series is
>>
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: "10.1 10.2" <mesa-stable at lists.freedesktop.org>
> 
> This hunk:
> 
>  +   /* ARB_vertex_array_bgra */
>  +   case GL_COLOR_ARRAY_SIZE:
>  +      array = &ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_COLOR0];
>  +      v->value_int = array->Format == GL_BGRA ? GL_BGRA : array->Size;
>  +      break;
>  +   case GL_SECONDARY_COLOR_ARRAY_SIZE:
>  +      array = &ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_COLOR1];
>  +      v->value_int = array->Format == GL_BGRA ? GL_BGRA : array->Size;
>  +      break;
>  +
> 
> Doesn't compile in 10.1:
> 
>   main/get.c: In function 'find_custom_value':
>   main/get.c:847:26: error: 'struct gl_array_attrib' has no member named 'VAO'
>        array = &ctx->Array.VAO->VertexAttrib[VERT_ATTRIB_COLOR0];
> 
> Is that an easy backport or a patch we should drop? (I tried to scan the
> patches on the other branches, but in my quick look I didn't see how to
> backport this patch).

It should be easy.  In commit 0dfe50f1, Ken renamed ArrayObj to VAO.
Making this patch compile on 10.1 should be as easy as s/VAO/ArrayObj/g.

> -Carl



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140606/b29e780b/attachment-0001.sig>