[Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

[Brian Paul]

On 06/18/2014 02:05 PM, Ian Romanick wrote:
> On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote:
>> On Intel hardware when a geometry shader outputs GL_POINTS primitives we
>> only need to emit vertex control bits if it emits vertices to non-zero
>> streams, so use a flag to track this.
>>
>> This flag will be set to TRUE when a geometry shader calls EmitStreamVertex()
>> or EndStreamPrimitive() with a non-zero stream parameter in a later patch.
>> ---
>>   src/mesa/main/mtypes.h     | 2 ++
>>   src/mesa/main/shaderapi.c  | 1 +
>>   src/mesa/main/shaderobj.c  | 1 +
>>   src/mesa/program/program.c | 1 +
>>   4 files changed, 5 insertions(+)
>>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index f45dde4..5bc710e 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -2178,6 +2178,7 @@ struct gl_geometry_program
>>                              GL_TRIANGLES, or GL_TRIANGLES_ADJACENCY_ARB */
>>      GLenum OutputType; /**< GL_POINTS, GL_LINE_STRIP or GL_TRIANGLE_STRIP */
>>      GLboolean UsesEndPrimitive;
>> +   GLboolean UsesStreams;
>
> For things that are not visible to the GL API, we've been trying to
> transition away from GL types.  Unless Brian or Chris object, I think
> I'd rather have this be bool (and true / false below).

Sounds fine.

-Brian