[Mesa-dev] [PATCH 11/24] targets/pipe-loader: move LLVM_LIBS handling inside PIPE_LIBS

[Matt Turner]

On Thu, Mar 27, 2014 at 2:00 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> This lets us have only one if HAVE_MESA_LLVM block, rather than
> one for each driver.
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/gallium/targets/pipe-loader/Makefile.am | 34 ++++++++++-------------------
>  1 file changed, 11 insertions(+), 23 deletions(-)
>
> diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am
> index 8e76d41..fae4fa3 100644
> --- a/src/gallium/targets/pipe-loader/Makefile.am
> +++ b/src/gallium/targets/pipe-loader/Makefile.am
> @@ -52,11 +52,13 @@ AM_LDFLAGS = \
>         -Wl,--version-script=$(top_srcdir)/src/gallium/targets/pipe-loader/pipe.link
>
>  if HAVE_MESA_LLVM
> +PIPE_LIBS += $(LLVM_LIBS)

It would be kind of nice to not just tack this onto an unrelated
variable. I see that we're already abusing PIPE_LIBS to contain
DLOPEN_LIBS, CLOCK_LIBS, -lpthread (grr, should be PTHREAD_LIBS), and
-lm.

Maybe do the whole thing as a follow on patch -- splitting these out
into a COMMON_LIBS variable or something.