[Mesa-dev] [PATCH 00/23] i965: Instruction compaction improvements.

[Matt Turner]

On Wed, May 21, 2014 at 4:26 PM, Eric Anholt <eric at anholt.net> wrote:
> Matt Turner <mattst88 at gmail.com> writes:
>
>> Available from
>>
>>    git://people.freedesktop.org/~mattst88/mesa compaction
>>
>> Highlights
>>
>>    - Print disassembly after instruction compaction, while still
>>      having control-flow graph information and higher-level IR
>>      annotations.
>>
>>    - Three improvements to instruction compaction increase number
>>      of compacted instructions by 5.4%.
>>
>>    - Adds INTEL_DEBUG=annotation to control printing higher-level
>>      IR annotations. Saves significant time and space requirements
>>      of shader-db.
>>
>>    - Print instruction counts and compaction stats with each shader.
>>      Will let shader-db parse this directly, rather than counting
>>      instructions.
>
> Assuming the deletion of brw_blorp_blit_test_compile is pulled to an
> initial patch instead of mid-series:
>
> Patches 1-6, 11-16 and 19 are:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> For patch 7-10, it seems like there should be some code sharing going
> on.

What would that look like? The code added in the generate_code()
functions uses five local variables, p->next_insn_offset, and inst, so
a shared function seems like it'd have to be pretty ugly.

I'm also reducing the number of lines of code in all of those already.