[Mesa-dev] [PATCH] rtasm,translate: Re-enable SSE on Mingw64.

[Jose Fonseca]

No idea. But the impression I generally have is MinGW has come a long 
way since then (3 years ago.)

I just noticed this while doing `git grep MINGW`.  Because ideally we 
should have very little things that depend on __MINGW32__ -- _WIN32 (ie. 
platform), or __GNUC__ or _MSC_VER (ie compiler) make sense, but very 
rarely should we need to take special cases for mingw itself.

Jose


On 19/11/14 14:50, Roland Scheidegger wrote:
> Reviewed-by: Roland Scheidegger <sroland at vmware.com>
>
> Do you know if that's due to MinGW changes or something else why it no
> longer causes crashes?
>
> Roland
>
> Am 19.11.2014 um 13:10 schrieb jfonseca at vmware.com:
>> From: José Fonseca <jfonseca at vmware.com>
>>
>> This reverts f4dd0991719ef3e2606920c5100b372181c60899.
>>
>> The src/gallium/tests/unit/translate_test.c gives the same results on
>> MinGW 64-bits as on Linux 64-bits.  And since MinGW is often used for
>> development/testing due to its convenience, it's better not to have this
>> sort of differences relative to MSVC.
>> ---
>>   src/gallium/auxiliary/rtasm/rtasm_x86sse.c      | 2 +-
>>   src/gallium/auxiliary/translate/translate_sse.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/gallium/auxiliary/rtasm/rtasm_x86sse.c b/src/gallium/auxiliary/rtasm/rtasm_x86sse.c
>> index 24ff820..f963788 100644
>> --- a/src/gallium/auxiliary/rtasm/rtasm_x86sse.c
>> +++ b/src/gallium/auxiliary/rtasm/rtasm_x86sse.c
>> @@ -25,7 +25,7 @@
>>   #include "pipe/p_config.h"
>>   #include "util/u_cpu_detect.h"
>>
>> -#if defined(PIPE_ARCH_X86) || (defined(PIPE_ARCH_X86_64) && !defined(__MINGW32__))
>> +#if defined(PIPE_ARCH_X86) || defined(PIPE_ARCH_X86_64)
>>
>>   #include "pipe/p_compiler.h"
>>   #include "util/u_debug.h"
>> diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate/translate_sse.c
>> index c7c53b3..c7b6c36 100644
>> --- a/src/gallium/auxiliary/translate/translate_sse.c
>> +++ b/src/gallium/auxiliary/translate/translate_sse.c
>> @@ -35,7 +35,7 @@
>>   #include "translate.h"
>>
>>
>> -#if (defined(PIPE_ARCH_X86) || (defined(PIPE_ARCH_X86_64) && !defined(__MINGW32__))) && !defined(PIPE_SUBSYSTEM_EMBEDDED)
>> +#if (defined(PIPE_ARCH_X86) || defined(PIPE_ARCH_X86_64)) && !defined(PIPE_SUBSYSTEM_EMBEDDED)
>>
>>   #include "rtasm/rtasm_cpu.h"
>>   #include "rtasm/rtasm_x86sse.h"
>>
>