[Mesa-dev] [PATCH 2/2] i965: Don't overwrite the math SFID with conditional mod.

[Matt Turner]

On Sat, Nov 22, 2014 at 1:03 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Friday, November 21, 2014 12:43:43 PM Matt Turner wrote:
>> Ben was asking about the undocumented restriction that the math
>> instruction cannot use the dependency control hints. I went to reconfirm
>> and disabled the is_math() check in opt_set_dependency_control() and saw
>> that the disassembled math instructions with dependency hints had a
>> bogus SFID. We were mistakenly overwriting it by setting an empty
>
> "bogus FC" or "bogus math function".
>
> Yow.  I sure don't remember seeing FC == 0 back when we were setting
> dependency control instructions on math.  Maybe this crept in after
> we disabled them.  Good catch, though!

Yes, I believe it did (I think it was my fault, in fact! :)

> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

For both?