[Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.

[Kenneth Graunke]

On Saturday, August 01, 2015 05:43:26 PM Emil Velikov wrote:
> On 6 July 2015 at 21:40, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote:
> >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> >> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a
> >> > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX
> >> > information.)   In other words, it's been missing since we moved to
> >> > dynamic binding table slot assignments.
> >>
> >> Author:     Eric Anholt <eric at anholt.net>
> >> AuthorDate: Wed Oct 2 14:07:40 2013 -0700
> >> CommitDate: Tue Oct 15 10:18:42 2013 -0700
> >>
> >> Dang.
> >>
> >> How did you find this?
> >
> > After reading Eero's latest performance analysis observations, I decided
> > to try marking render targets uncached (MOCS = UC) when blending and
> > logic ops (i.e. things that cause render target reads) are disabled.
> >
> > This necessitated adding _NEW_COLOR.  Then I realized
> > BRW_NEW_FS_PROG_DATA was just plain missing.
> >
> Seems like this patch has fallen between the cracks. Can anyone take a
> look or let me know if it's no longer applicable.
> 
> Thanks
> Emil

Chris and I informally NAK'd it on IRC, sorry.  It turns out that
render_target_start is always 0, so omitting the bit should be harmless.

We thought about sending a patch to delete the field and hardcode 0
instead...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150802/b9afbc37/attachment.sig>