[Mesa-dev] [PATCH v2 21/21] i965/gen7: Resolve GCC sign-compare warning.

[Thomas Helland]

2015-08-06 10:47 GMT+02:00 Rhys Kidd <rhyskidd at gmail.com>:
> That is correct Thomas. I do not have commit access to push these myself.
>

Oh, wow. Top-quoting is bad. Sorry about that.
After a discussion with Matt we decided that I'll pull these
down, add my R-b, and put it in a branch with some of my
own reviewed patches. I'll then get someone to merge the
patches some time before the 11.0 branchpoint (21st August).

BR,
Thomas

> On 6 August 2015 at 18:35, Thomas Helland <thomashelland90 at gmail.com> wrote:
>>
>> The series looks good. You could probably s/GLuint/unsigned
>> in patch three as it is not "in the API", but that's a nitpick.
>> (You're fixing warnings, and not making things worse)
>> Either way the series is:
>>
>> Reviewed-by: Thomas Helland <thomashelland90 at gmail.com>
>>
>> Someone else needs to push these for you (?).
>> AFAIK you don't have commit access, and neither do I.
>>
>> 2015-08-06 8:34 GMT+02:00 Rhys Kidd <rhyskidd at gmail.com>:
>> > mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c: In function
>> > 'gen7_upload_3dstate_so_decl_list':
>> > mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c:119:22: warning:
>> > comparison between signed and unsigned integer expressions [-Wsign-compare]
>> >     for (int i = 0; i < linked_xfb_info->NumOutputs; i++) {
>> >                       ^
>> >
>> > Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
>> > ---
>> >  src/mesa/drivers/dri/i965/gen7_sol_state.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c
>> > b/src/mesa/drivers/dri/i965/gen7_sol_state.c
>> > index 41573a8..8cd2fc4 100644
>> > --- a/src/mesa/drivers/dri/i965/gen7_sol_state.c
>> > +++ b/src/mesa/drivers/dri/i965/gen7_sol_state.c
>> > @@ -116,7 +116,7 @@ gen7_upload_3dstate_so_decl_list(struct brw_context
>> > *brw,
>> >     /* Construct the list of SO_DECLs to be emitted.  The formatting of
>> > the
>> >      * command is feels strange -- each dword pair contains a SO_DECL
>> > per stream.
>> >      */
>> > -   for (int i = 0; i < linked_xfb_info->NumOutputs; i++) {
>> > +   for (unsigned i = 0; i < linked_xfb_info->NumOutputs; i++) {
>> >        int buffer = linked_xfb_info->Outputs[i].OutputBuffer;
>> >        uint16_t decl = 0;
>> >        int varying = linked_xfb_info->Outputs[i].OutputRegister;
>> > --
>> > 2.1.4
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>