[Mesa-dev] [PATCH v2] mesa: AtomicBufferBindings should be initialized to zero.

[Erik Faye-Lund]

On Thu, Aug 13, 2015 at 12:59 PM, Marta Lofstedt
<marta.lofstedt at linux.intel.com> wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
>
> According to OpenGL specification version 4.5 table 23.46
> and OpenGL ES specification version 3.1 table 20.31:
> ATOMIC_COUNTER_BUFFER_START and ATOMIC_COUNTER_BUFFER_SIZE
> should have the initial value of zero.
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> ---
>  src/mesa/main/bufferobj.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index 1cdea93..e17b41c 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -866,8 +866,8 @@ _mesa_init_buffer_objects( struct gl_context *ctx )
>        _mesa_reference_buffer_object(ctx,
>                                     &ctx->AtomicBufferBindings[i].BufferObject,
>                                     ctx->Shared->NullBufferObj);
> -      ctx->AtomicBufferBindings[i].Offset = -1;
> -      ctx->AtomicBufferBindings[i].Size = -1;
> +      ctx->AtomicBufferBindings[i].Offset = 0;
> +      ctx->AtomicBufferBindings[i].Size = 0;
>     }
>  }
>

Looks good to me!

Reviewed-by: Erik Faye-Lund <kusmabite at gmail.com>