[Mesa-dev] [PATCH 0/6] Copyright / license pet peeves

Ian Romanick idr at freedesktop.org
Wed Aug 19 19:48:59 PDT 2015


My justification for these patches is that I was annoyed. :)

After this series, the following script tells me that the differences in
the license / copyright headers of all the files in
src/mesa/drivers/dri/i965 is pretty minimal.  I have summarized the
differences below.

    #! /bin/bash
    j=brw_binding_tables.c
    for i in *.c *.h *.cpp; do
        echo diff -ud $j $i
        diff -ud \
             <(head -$(grep -n '^ [*]/' $j | head -1 | cut -d: -f1) $j) \
             <(head -$(grep -n '^ [*]/' $i | head -1 | cut -d: -f1) $i | \
	     sed 's/ 20.. Intel Corporation$/ 2013 Intel Corporation/')
        echo
    done

The following files have no license or copyright information:

    intel_batchbuffer.h
    intel_tex.c
    intel_tex_image.c

brw_disasm.c has a completely different license (2 clause BSD?).  I'm
not sure why keithp picked that... or kept the copyright to himself.

Many files contain the following diff:

- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * VMWARE AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

Many files contain the following diff:

- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
+ * DAMAGES OR OTHER

intel_copy_image contains the following diff:

- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
+ * The above copyright notice and this permission notice shall be included
+ * in all copies or substantial portions of the Software.

gen6_gs_visitor.cpp has an extra note on the license:

+ *
+ * This code is based on original work by Ilia Mirkin.

I hope that I can just "fix" all of the differences except perhaps
brw_disasm.c.  I'm not a lawyer (and you probably aren't either), so I'm
just going to ask one what I'm allowed to do.

In case the patches never make it to the list (some are quite large), I
have put this all on the i965-license-header branch of my fd.o tree.

Ian Romanick (6):
      i965: Remove by-lines from file headers
      i965: Remove horizontal bars from file header comments
      i965: Fix typos in license
      i965: Re-wrap lines in the license, part 1
      i965: Various trivial changes to file headers
      i965: Re-wrap lines in the license, part 2



More information about the mesa-dev mailing list