[Mesa-dev] [PATCH] i965: Remove extra irb->need_downsample = true from fast clear code.

Matt Turner mattst88 at gmail.com
Wed Feb 4 17:08:45 PST 2015


On Wed, Jan 14, 2015 at 5:11 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, Jan 14, 2015 at 8:54 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> In the common case, this is redundant - we set it a few lines later.
>>
>> However, when irb->mt->fast_clear_state == INTEL_FAST_CLEAR_STATE_CLEAR,
>> this causes irb->need_downsample to be set, even though we skip altering
>> the buffer at all.  We don't want to do that.
>
> What is the result of that? Do we end up doing extra work because we
> needlessly set need_downsample?

To make sure this doesn't get lost... ping.


More information about the mesa-dev mailing list