[Mesa-dev] [PATCH 08/32] i965/fs: Fix stack allocation of fs_inst and stop stealing src array provided on construction.

Matt Turner mattst88 at gmail.com
Fri Feb 6 12:43:05 PST 2015


On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez <currojerez at riseup.net> wrote:
> Using 'ralloc*(this, ...)' is wrong if the object has automatic
> storage or was allocated through any other means.  Use normal dynamic
> memory instead.
> ---

I don't see any places we were allocating an fs_inst via a mechanism
other than ralloc. Does one exist, or is this commit in preparation
for doing so?

I understand that in general "stealing" the source array might be
somewhat unexpected, but as far as I know we do this with
load_payload, where it seems pretty clear. Is this just an issue of
taste?


More information about the mesa-dev mailing list