[Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

Kenneth Graunke kenneth at whitecape.org
Sat Feb 14 12:12:38 PST 2015


On Saturday, February 14, 2015 04:37:25 PM sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> Since dropping some NV_fragment_program opcodes (commits
> 868f95f1da74cf6dd7468cba1b56664aad585ccb, a3688d686f147f4252d19b298ae26d4ac72c2e08)
> we can no longer parse all opcodes necessary for this extension, leading
> to bugs (https://bugs.freedesktop.org/show_bug.cgi?id=86980).
> Hence don't announce support for it in swrast.
> (The rest of the infrastructure ranging from dead opcodes (TXP_NV) to
> parsing condition codes along with the NV_fragment_program_option variable
> in the context could probably nuked too this is just a minimal fix appropriate
> for stable too.)
> ---
>  src/mesa/main/extensions.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 220b220..c94009f 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -511,7 +511,6 @@ _mesa_enable_sw_extensions(struct gl_context *ctx)
>     ctx->Extensions.NV_point_sprite = GL_TRUE;
>     ctx->Extensions.NV_texture_env_combine4 = GL_TRUE;
>     ctx->Extensions.NV_texture_rectangle = GL_TRUE;
> -   ctx->Extensions.NV_fragment_program_option = GL_TRUE;
>     ctx->Extensions.EXT_gpu_program_parameters = GL_TRUE;
>     ctx->Extensions.OES_standard_derivatives = GL_TRUE;
>     ctx->Extensions.TDFX_texture_compression_FXT1 = GL_TRUE;
> 

Nuking this extension would make some compiler work I'm planning to do
easier, so I'd definitely be interested to hear whether you still need
it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150214/9d598441/attachment.sig>


More information about the mesa-dev mailing list