[Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

Carl Worth cworth at cworth.org
Sat Feb 28 10:26:52 PST 2015


On Fri, Feb 27 2015, Ian Romanick wrote:
> All dd functions take a gl_context as the first parameter.  Instead of
> removing it, just silence the warning.

For code using gcc, I really prefer the __attribute__((__unused__))
style, (though, obviously hidden in a reasonable looking macro). That
results in cleaner looking code than these weird unused expressions
being cast to void.

Does MSVC have an equivalent? Or, does it not emit the warning in the
first place such that we could just define the macro as empty outside of
gcc?

So there's room for investigation here. In the meantime:

Reviewed-by: Carl Worth <cworth at cworth.org>

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150228/f181ebea/attachment.sig>


More information about the mesa-dev mailing list