[Mesa-dev] [PATCH 52/53] st/nine: Change comment related to vertex shader inputs not matching declaration

[Ilia Mirkin]

On Wed, Jan 7, 2015 at 11:37 AM, Axel Davy <axel.davy at ens.fr> wrote:
> Signed-off-by: Axel Davy <axel.davy at ens.fr>
> ---
>  src/gallium/state_trackers/nine/nine_state.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c
> index 09b4401..99173fa 100644
> --- a/src/gallium/state_trackers/nine/nine_state.c
> +++ b/src/gallium/state_trackers/nine/nine_state.c
> @@ -214,11 +214,12 @@ update_vertex_elements(struct NineDevice9 *device)
>              if (state->stream_freq[b] & D3DSTREAMSOURCE_INSTANCEDATA)
>                  ve[n].instance_divisor = state->stream_freq[b] & 0x7FFFFF;
>          } else {
> -            /* TODO:
> -             * If drivers don't want to handle this, insert a dummy buffer.
> -             * But on which stream ?
> -             */
> -            /* no data, disable */
> +            /* TODO: msdn doesn't precise what should happen when the vertex

s/precise/specify/

"precise" in English doesn't work quite the same as in French.

> +             * declaration doesn't match the vertex shader inputs.
> +             * Some website say the code will pass but nothing will get rendered.

"Some websites say" or "Some website says"

> +             * We should check and implement the correct behaviour. */
> +            /* Put PIPE_FORMAT_NONE.
> +             * Some drivers (r300) are very unhappy with that */
>              ve[n].src_format = PIPE_FORMAT_NONE;
>              ve[n].src_offset = 0;
>              ve[n].instance_divisor = 0;
> --
> 2.1.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev