[Mesa-dev] [Bug 88335] format_pack.c:9567:22: error: expected ')'

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 12 11:35:19 PST 2015


https://bugs.freedesktop.org/show_bug.cgi?id=88335

Vinson Lee <vlee at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected
                 CC|                            |jason at jlekstrand.net,
                   |                            |siglesias at igalia.com
                 OS|FreeBSD                     |All

--- Comment #1 from Vinson Lee <vlee at freedesktop.org> ---
Build is also broken on Mac OS X.

e0439f750557bc6880a8a4eccb38256fafd63fae is the first bad commit
commit e0439f750557bc6880a8a4eccb38256fafd63fae
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Thu Aug 21 12:38:05 2014 -0700

    mesa: Autogenerate most of format_pack.c

    We were auto-generating it before.  The problem was that the autogeneration
    tool we were using was called "copy, paste, and edit".  Let's use a more
    sensible solution.

    Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>

    v2 by Samuel Iglesias <siglesias at igalia.com>
    - Remove format_pack.c as it is now autogenerated
    - Add usage of INDENT_FLAGS in Makefile.am
    - Remove trailing blank line

    v3 by Samuel Iglesias <siglesias at igalia.com>
    - Merge format_convert.py into format_parser.py
       - Adapt pack_*_* function generations
    - Fix out-of-tree build

    v4 by Samuel Iglesias <siglesias at igalia.com>
    - _get_datatype() is now a helper function

    v5 by Samuel Iglesias <siglesias at igalia.com>
    - format_pack.c.mako is now format_pack.py, with the template code
      inlined. It now auto-generates format_pack.c
    - Simplify Makefile.am change.
    - Modify SConscript to build format_pack.c with scons.
    - Remove run_mako.py
    - Add format_pack.c to gitignore

    v6 by Samuel Iglesias <siglesias at igalia.com>:
    - Don't allow float to non-normalized integer format conversions.
    - Add non-normalized formats support for ubyte packing functions. Merge
    the previously separated patch.
    - Add clamping for non-normalized integer formats in pack_ubyte*()

    v7 by Samuel Iglesias <siglesias at igalia.com>:
    - Add assert to check that sRGB formats are 8-bit size.

    Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
    Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

:040000 040000 63515b5b815382ffdd60de088cf3fef8baf3d255
b0dffc189c7eb0fe800f4d11bac5cdde6de7e268 M    src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150112/2eaba7a5/attachment.html>


More information about the mesa-dev mailing list