[Mesa-dev] [PATCH 2/3] util: Move main/set to util/hash_set

[Eric Anholt]

Jason Ekstrand <jason at jlekstrand.net> writes:

> ---
>  src/glsl/nir/nir.h                    |   2 +-
>  src/mesa/Makefile.sources             |   2 -
>  src/mesa/drivers/dri/i965/intel_fbo.c |   2 +-
>  src/mesa/main/set.c                   | 346 ----------------------------------
>  src/mesa/main/set.h                   |  94 ---------
>  src/mesa/main/shared.c                |   2 +-
>  src/mesa/main/syncobj.c               |   2 +-
>  src/mesa/main/vdpau.c                 |   2 +-
>  src/util/Makefile.sources             |   2 +
>  src/util/hash_set.c                   | 346 ++++++++++++++++++++++++++++++++++
>  src/util/hash_set.h                   |  94 +++++++++
>  11 files changed, 447 insertions(+), 447 deletions(-)
>  delete mode 100644 src/mesa/main/set.c
>  delete mode 100644 src/mesa/main/set.h
>  create mode 100644 src/util/hash_set.c
>  create mode 100644 src/util/hash_set.h

I'm not a fan of renaming the files to hash_set.[ch].  The name of the
datatype is "set", the function names are "set", and people call these
things "sets".

I'm not going to block based on that, but I'd rather see the filenames
retained.  Other than this, the series is:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150116/0fd1ecac/attachment.sig>