[Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

Eric Anholt eric at anholt.net
Mon Jan 26 11:22:32 PST 2015


Jason Ekstrand <jason at jlekstrand.net> writes:

> On Mon, Jan 26, 2015 at 11:15 AM, Eric Anholt <eric at anholt.net> wrote:
>
>> Jason Ekstrand <jason at jlekstrand.net> writes:
>>
>> > Previously, we called the abs() function in math.h.  However, this
>> involves
>> > unnecessarily going through double.  This commit changes it to use
>> integers
>> > directly with a ternary.
>>
>> Or just use fabs()?
>>
>
> This is for the integer version.  We don't want to go through floats or
> doubles.

Hah, misread.  Yeah,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150126/2becbfc9/attachment.sig>


More information about the mesa-dev mailing list