[Mesa-dev] [PATCH 07/12] glsl: automake: remove custom AM_V_LEX/YACC

Emil Velikov emil.l.velikov at gmail.com
Fri Jul 17 11:35:07 PDT 2015


On 17 July 2015 at 19:02, Matt Turner <mattst88 at gmail.com> wrote:
> On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> We already use AM_V_GEN in src/mesa for lex/yacc. Plus we use the
>> generic macro for python generated sources as well.
>
> I'm in favor of removing "extras" when they cause problems, but I'm
> not aware of any -- most of the lines git blame to the original
> commit.
>
It is strange that we have these in one place but not the other. As-is
It's a bit confusing - do you have any objections if we keep them and
add a pair in src/mesa ?

> Maybe we should do a survey of required automake versions and see if
> we can require >= 1.12? From before, Red Hat wanted 1.11 support for
> RHEL.... 5?
Would be nice to nuke them, but as you mentioned 1.11 is still used
iirc (from a quick chat with Dave (?) a month or so ago).

Cheers
Emil


More information about the mesa-dev mailing list