[Mesa-dev] [PATCH 1/7] configure.ac: null, android, gdi are not valid egl-platforms

Thomas Helland thomashelland90 at gmail.com
Mon Jul 20 16:00:54 PDT 2015


Hi Emil,

I looked at the whole series, but didn't really feel qualified
to review the whole bunch. I've sent reviews on the patches
I felt I had a good take on. If you don't get anyone else to
review the remainder then shout out and I'll give it a shot.

- Thomas

2015-07-17 22:57 GMT+02:00 Emil Velikov <emil.l.velikov at gmail.com>:
> Would anyone be interested is skimming over this trivial series ?
>
> Thanks
> Emil
>
> On 10/07/15 18:49, Emil Velikov wrote:
>> ... and update the documentation to reflect reality.
>> null and gdi are gone, and surfaceless is a recent addition.
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  configure.ac  | 3 ---
>>  docs/egl.html | 6 +++---
>>  2 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 9ffd69d..f3a24f2 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1763,9 +1763,6 @@ for plat in $egl_platforms; do
>>                       AC_MSG_ERROR([EGL platform surfaceless requires libdrm >= $LIBDRM_REQUIRED])
>>               ;;
>>
>> -     android|gdi|null)
>> -             ;;
>> -
>>       *)
>>               AC_MSG_ERROR([EGL platform '$plat' does not exist])
>>               ;;
>> diff --git a/docs/egl.html b/docs/egl.html
>> index 3ab1a60..30d8687 100644
>> --- a/docs/egl.html
>> +++ b/docs/egl.html
>> @@ -88,10 +88,10 @@ types such as <code>EGLNativeDisplayType</code> or
>>  <code>EGLNativeWindowType</code> defined for.</p>
>>
>>  <p>The available platforms are <code>x11</code>, <code>drm</code>,
>> -<code>wayland</code>, <code>null</code>, <code>android</code>,
>> -<code>haiku</code>, and <code>gdi</code>.  The <code>android</code> platform
>> +<code>wayland</code>, <code>surfaceless</code>, <code>android</code>,
>> +and <code>haiku</code>.  The <code>android</code> platform
>>  can only be built as a system component, part of AOSP, while the
>> -<code>haiku</code> and <code>gdi</code> platforms can only be built with SCons.
>> +<code>haiku</code> platforms can only be built with SCons.
>>  Unless for special needs, the build system should
>>  select the right platforms automatically.</p>
>>
>>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list