[Mesa-dev] [PATCH 01/18] gallium/util: clear up that debug_get_flags_option returns a 64-bit mask

Kai Wasserbäch kai at dev.carbon-project.org
Tue Jul 28 10:24:59 PDT 2015


Brian Paul wrote on 28.07.2015 18:40:
> On 07/28/2015 10:35 AM, Kai Wasserbäch wrote:
>> Marek Olšák wrote on 28.07.2015 12:05:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> ---
>>>   src/gallium/auxiliary/util/u_debug.c | 8 ++++----
>>>   src/gallium/auxiliary/util/u_debug.h | 6 +++---
>>>   2 files changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/src/gallium/auxiliary/util/u_debug.c
>>> b/src/gallium/auxiliary/util/u_debug.c
>>> index cf6eca7..b4503de 100644
>>> --- a/src/gallium/auxiliary/util/u_debug.c
>>> +++ b/src/gallium/auxiliary/util/u_debug.c
>>> @@ -256,12 +256,12 @@ static boolean str_has_option(const char *str, const
>>> char *name)
>>>      return FALSE;
>>>   }
>>>
>>> -unsigned long
>>> +uint64_t
>>>   debug_get_flags_option(const char *name,
>>>                          const struct debug_named_value *flags,
>>> -                       unsigned long dfault)
>>> +                       uint64_t dfault)
>>
>> Since you already touch this, maybe fix the typo as well? (s/dfault/default/)
> 
> Can't.  'default' is a C reserved word. :)
> 
> In other places you'll see 'templat' instead of 'template' for similar reasons
> with C++.

Ahrg, yes. Totally went for the "typo". Not the first time I stumbled over one
of these. Sorry for the noise.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150728/c5a02734/attachment.sig>


More information about the mesa-dev mailing list