[Mesa-dev] [PATCH 2/6] mesa/es3.1: Correct error code for illegal internal formats

Erik Faye-Lund kusmabite at gmail.com
Tue Jun 23 06:22:59 PDT 2015


On Tue, Jun 23, 2015 at 3:11 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt
> <marta.lofstedt at linux.intel.com> wrote:
>> From: Marta Lofstedt <marta.lofstedt at intel.com>
>>
>> According to GLES 3.1 CTS test:
>> ES31-CTS.texture_storage_multisample.
>> APIGLTexStorage2DMultisample.
>> multisample_texture_tex_storage_2d_non_color_depth_or_stencil_
>> internal_formats_receted.
>>
>> An illegal internal format should generate a
>> GL_INVALID_ENUM error.
>>
>
> OpenGL ES 3.1, section 8.8 defines this, not the CTS:
>
> "An INVALID_ENUM error is generated if sizedinternalformat is not
> colorrenderable, depth-renderable, or stencil-renderable (as defined
> in section 9.4)."

By the way, OpenGL 4.5 also defines this, so the patch should probably
skip that condition.


More information about the mesa-dev mailing list