[Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

[Samuel Iglesias Gonsálvez]

On Wed, 2015-03-04 at 15:35 +0100, Kai Wasserbäch wrote:
> Samuel Iglesias Gonsálvez wrote on 04.03.2015 07:54:
> > On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote:
> >> Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56:
> >>> This output variables gives more flexibility for future changes
> >>> in autoconf to detect if it is needed to auto-generate files and
> >>> check for the auto-generation dependencies.
> >>>
> >>> It is still returning error when Python is not installed.
> >>>
> >>> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> >>> ---
> >>>  configure.ac                      | 9 ++++++++-
> >>>  m4/ax_check_python_mako_module.m4 | 4 ++--
> >>>  2 files changed, 10 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/configure.ac b/configure.ac
> >>> index 2ba79ef..ff7d6c9 100644
> >>> --- a/configure.ac
> >>> +++ b/configure.ac
> >>> @@ -114,7 +114,14 @@ if test "x$INDENT" != "xcat"; then
> >>>      fi
> >>>  fi
> >>>  
> >>> -AX_CHECK_PYTHON_MAKO_MODULE(0.3.4)
> >>> +PYTHON_MAKO_REQUIRED=0.3.4
> >>
> >> Can you put that up into the section where all the other minimum versions are
> >> defined? That would be more consistent.
> >>
> > 
> > Yeah, I'll do it. Has this patch your R-b with this change?
> 
> Sure:
>   Reviewed-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> 
> Bonus nit: can we change the subject to something like:
>  configure: Introduce new output variable to ax_check_python_mako_module.m4
> 

OK.

Thanks!

Sam

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150304/31a23a39/attachment.sig>