[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog

Tim Rowley timothy.o.rowley at intel.com
Mon May 4 12:57:39 PDT 2015


This was working before because it failed into generating the more
general case lighting equation.

diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c
index 7fdd9ba..cce0636 100644
--- a/src/mesa/main/ffvertex_prog.c
+++ b/src/mesa/main/ffvertex_prog.c
@@ -135,7 +135,7 @@ static GLboolean check_active_shininess( struct gl_context *ctx,
        (key->light_color_material_mask & (1 << attr)))
       return GL_TRUE;
 
-   if (key->varying_vp_inputs & VERT_ATTRIB_GENERIC(attr))
+   if (key->varying_vp_inputs & (1 << VERT_ATTRIB_GENERIC(attr)))
       return GL_TRUE;
 
    if (ctx->Light.Material.Attrib[attr][0] != 0.0F)


More information about the mesa-dev mailing list