[Mesa-dev] [PATCH] glsl: validate binding qualifier on block members

Samuel Iglesias Gonsálvez siglesias at igalia.com
Fri Oct 2 00:37:36 PDT 2015


Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

On 02/10/15 09:23, Tapani Pälli wrote:
> Fixes following Piglit test:
> 	member-invalid-binding-qualifier.frag
> 
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/glsl/ast_to_hir.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index 6899a55..7bcf182 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@ -5765,6 +5765,10 @@ ast_process_structure_or_interface_block(exec_list *instructions,
>  
>           const struct ast_type_qualifier *const qual =
>              & decl_list->type->qualifier;
> +
> +         if (qual->flags.q.explicit_binding)
> +            validate_binding_qualifier(state, &loc, decl_type, qual);
> +
>           if (qual->flags.q.std140 ||
>               qual->flags.q.std430 ||
>               qual->flags.q.packed ||
> 


More information about the mesa-dev mailing list