[Mesa-dev] [PATCH] nir/prog: Don't double-insert the fog-coord variable

Jason Ekstrand jason at jlekstrand.net
Thu Oct 15 09:21:53 PDT 2015


nir_variable_create already inserts it in the right list for us so
inserting it again causes a linked list corruption.
---
 src/mesa/program/prog_to_nir.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
index fe8c238..da61a2b 100644
--- a/src/mesa/program/prog_to_nir.c
+++ b/src/mesa/program/prog_to_nir.c
@@ -1001,11 +1001,10 @@ setup_registers_and_variables(struct ptn_compile *c)
             store->src[0] = nir_src_for_ssa(f001);
             nir_builder_instr_insert(b, &store->instr);
 
-            /* Insert the real input into the list so the driver has real
-             * inputs, but set c->input_vars[i] to the temporary so we use
+            /* We inserted the real input into the list so the driver has real
+             * inputs, but we set c->input_vars[i] to the temporary so we use
              * the splatted value.
              */
-            exec_list_push_tail(&shader->inputs, &var->node);
             c->input_vars[i] = fullvar;
             continue;
          }
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list