[Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

Ilia Mirkin imirkin at alum.mit.edu
Tue Oct 20 08:26:21 PDT 2015


On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák <maraeo at gmail.com> wrote:
> +       /* This is not needed if state trackers set last_layer correctly. */
> +       if (state->target == PIPE_TEXTURE_1D ||
> +           state->target == PIPE_TEXTURE_2D ||
> +           state->target == PIPE_TEXTURE_RECT ||
> +           state->target == PIPE_TEXTURE_CUBE)
> +               last_layer = state->u.tex.first_layer;
> +

Did you observe state trackers messing this one up, or just being
defensive? Also for cube, normally last layer would be first_layer +
5...

  -ilia


More information about the mesa-dev mailing list