[Mesa-dev] [PATCH 1/2] radeonsi: add support for Stoney asics (v2)

[Alex Deucher]

On Thu, Oct 22, 2015 at 10:44 PM, Michel Dänzer <michel at daenzer.net> wrote:
> On 23.10.2015 01:09, Alex Deucher wrote:
>> From: Samuel Li <samuel.li at amd.com>
>>
>> v2 (agd): rebase on mesa master, split pci ids to
>> separate commit
>>
>> Signed-off-by: Samuel Li <samuel.li at amd.com>
>
> [...]
>
>> @@ -540,6 +541,7 @@ const char *r600_get_llvm_processor_name(enum radeon_family family)
>>       case CHIP_ICELAND: return "iceland";
>>       case CHIP_CARRIZO: return "carrizo";
>>       case CHIP_FIJI: return "fiji";
>> +     case CHIP_STONEY: return "stoney";
>>       default: return "";
>>       }
>>  }
>
> Do we need a fallback here for existing versions of LLVM which don't
> recognize "stoney" yet?

Is there a way to check if a particular llvm version supports a
specific processor name?  Or should we just do something like return
carrizo for llvm 3.7 and stoney for newer versions?

Alex

>
> Other than that, looks good to me.
>
>
> Patch 2 is
>
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer