[Mesa-dev] [PATCH 2/3] util: Add list_is_single() helper function

[Matt Turner]

On Fri, Oct 23, 2015 at 8:55 AM, Eduardo Lima Mitev <elima at igalia.com> wrote:
> Returns true is the list has exactly one element, otherwise returns false.
> ---
>  src/util/list.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/src/util/list.h b/src/util/list.h
> index b98ce59..2b03461 100644
> --- a/src/util/list.h
> +++ b/src/util/list.h
> @@ -99,6 +99,14 @@ static inline bool list_empty(struct list_head *list)
>     return list->next == list;
>  }
>
> +/**
> + * Return true is the list has exactly one element, otherwise return false.

How about "Returns whether the list has exactly one element."

> + */
> +static inline bool list_is_single(struct list_head *list)

Doesn't look like anywhere else uses const arguments, but this could
be. No matter...

> +{
> +   return list->next != NULL && list->next->next == list;
> +}
> +

Reviewed-by: Matt Turner <mattst88 at gmail.com>