[Mesa-dev] [PATCH 1/2] mesa/sso: Add MESA_VERBOSE=api trace support

[Iago Toral]

On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote:
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/main/pipelineobj.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c
> index 51ee10f..c8c50fa 100644
> --- a/src/mesa/main/pipelineobj.c
> +++ b/src/mesa/main/pipelineobj.c
> @@ -230,6 +230,10 @@ _mesa_UseProgramStages(GLuint pipeline, GLbitfield stages, GLuint program)
>     struct gl_shader_program *shProg = NULL;
>     GLbitfield any_valid_stages;
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glUseProgramStages(%d, 0x%x, %d)\n",
> +                  pipeline, stages, program);
> +

It probably does not matter much, you since pieline and program and
unsigned we might want to use %y instead of %d here. The same in a bunch
of of the other hunks in this patch.

Either way,
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

>     if (!pipe) {
>        _mesa_error(ctx, GL_INVALID_OPERATION, "glUseProgramStages(pipeline)");
>        return;
> @@ -345,6 +349,9 @@ _mesa_ActiveShaderProgram(GLuint pipeline, GLuint program)
>     struct gl_shader_program *shProg = NULL;
>     struct gl_pipeline_object *pipe = _mesa_lookup_pipeline_object(ctx, pipeline);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glActiveShaderProgram(%d, %d)\n", pipeline, program);
> +
>     if (program != 0) {
>        shProg = _mesa_lookup_shader_program_err(ctx, program,
>                                                 "glActiveShaderProgram(program)");
> @@ -380,6 +387,9 @@ _mesa_BindProgramPipeline(GLuint pipeline)
>     GET_CURRENT_CONTEXT(ctx);
>     struct gl_pipeline_object *newObj = NULL;
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glBindProgramPipeline(%d)\n", pipeline);
> +
>     /* Rebinding the same pipeline object: no change.
>      */
>     if (ctx->_Shader->Name == pipeline)
> @@ -467,6 +477,9 @@ _mesa_DeleteProgramPipelines(GLsizei n, const GLuint *pipelines)
>     GET_CURRENT_CONTEXT(ctx);
>     GLsizei i;
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glDeleteProgramPipelines(%d, %p)\n", n, pipelines);
> +
>     if (n < 0) {
>        _mesa_error(ctx, GL_INVALID_VALUE, "glDeleteProgramPipelines(n<0)");
>        return;
> @@ -551,6 +564,9 @@ _mesa_GenProgramPipelines(GLsizei n, GLuint *pipelines)
>  {
>     GET_CURRENT_CONTEXT(ctx);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glGenProgramPipelines(%d, %p)\n", n, pipelines);
> +
>     create_program_pipelines(ctx, n, pipelines, false);
>  }
>  
> @@ -559,6 +575,9 @@ _mesa_CreateProgramPipelines(GLsizei n, GLuint *pipelines)
>  {
>     GET_CURRENT_CONTEXT(ctx);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glCreateProgramPipelines(%d, %p)\n", n, pipelines);
> +
>     create_program_pipelines(ctx, n, pipelines, true);
>  }
>  
> @@ -574,6 +593,9 @@ _mesa_IsProgramPipeline(GLuint pipeline)
>  {
>     GET_CURRENT_CONTEXT(ctx);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glIsProgramPipeline(%d)\n", pipeline);
> +
>     struct gl_pipeline_object *obj = _mesa_lookup_pipeline_object(ctx, pipeline);
>     if (obj == NULL)
>        return GL_FALSE;
> @@ -590,6 +612,10 @@ _mesa_GetProgramPipelineiv(GLuint pipeline, GLenum pname, GLint *params)
>     GET_CURRENT_CONTEXT(ctx);
>     struct gl_pipeline_object *pipe = _mesa_lookup_pipeline_object(ctx, pipeline);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glGetProgramPipelineiv(%d, %d, %p)\n",
> +                  pipeline, pname, params);
> +
>     /* Are geometry shaders available in this context?
>      */
>     const bool has_gs = _mesa_has_geometry_shaders(ctx);
> @@ -857,6 +883,9 @@ _mesa_ValidateProgramPipeline(GLuint pipeline)
>  {
>     GET_CURRENT_CONTEXT(ctx);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glValidateProgramPipeline(%d)\n", pipeline);
> +
>     struct gl_pipeline_object *pipe = _mesa_lookup_pipeline_object(ctx, pipeline);
>  
>     if (!pipe) {
> @@ -875,6 +904,10 @@ _mesa_GetProgramPipelineInfoLog(GLuint pipeline, GLsizei bufSize,
>  {
>     GET_CURRENT_CONTEXT(ctx);
>  
> +   if (MESA_VERBOSE & VERBOSE_API)
> +      _mesa_debug(ctx, "glGetProgramPipelineInfoLog(%d, %d, %p, %p)\n",
> +                  pipeline, bufSize, length, infoLog);
> +
>     struct gl_pipeline_object *pipe = _mesa_lookup_pipeline_object(ctx, pipeline);
>  
>     if (!pipe) {