[Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 1 11:17:37 PDT 2015


On Tue, Sep 01, 2015 at 06:40:39PM +0100, Neil Roberts wrote:
> It's legal to call glTexSubImage with zero values for the width,
> height or depth. Previously this was breaking the PBO access
> validation because it tries to work out the last pixel accessed by
> getting the pixel at height-1 and depth-1 which would end up with
> bogus values.

Hmm. this was the style I just copied to find the access size for the
meta_tex_image patch. Do we need to filter out no-op glTexSubImages in
the driver backend or will the core? At the moment, it looks like this
request will be passed along and processed by the drivers.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the mesa-dev mailing list