[Mesa-dev] [PATCH 12/12] auxiliary: fix the generated sources rules

[Ian Romanick]

On 07/17/2015 10:29 AM, Emil Velikov wrote:
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/gallium/auxiliary/Makefile.am | 29 +++++++++++++++++------------
>  1 file changed, 17 insertions(+), 12 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/Makefile.am b/src/gallium/auxiliary/Makefile.am
> index 04f77d0..a728162 100644
> --- a/src/gallium/auxiliary/Makefile.am
> +++ b/src/gallium/auxiliary/Makefile.am
> @@ -38,18 +38,23 @@ libgallium_la_SOURCES += \
>  
>  endif
>  
> -indices/u_indices_gen.c: $(srcdir)/indices/u_indices_gen.py
> -	$(AM_V_at)$(MKDIR_P) indices
> -	$(AM_V_GEN) $(PYTHON2) $< > $@
> -
> -indices/u_unfilled_gen.c: $(srcdir)/indices/u_unfilled_gen.py
> -	$(AM_V_at)$(MKDIR_P) indices
> -	$(AM_V_GEN) $(PYTHON2) $< > $@
> -
> -util/u_format_table.c: $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format_pack.py $(srcdir)/util/u_format_parse.py $(srcdir)/util/u_format.csv
> -	$(AM_V_at)$(MKDIR_P) util
> -	$(AM_V_GEN) $(PYTHON2) $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format.csv > $@
> -
> +MKDIR_GEN = $(AM_V_at)$(MKDIR_P) $(@D)
> +PYTHON_GEN =  $(AM_V_GEN)$(PYTHON2) $(PYTHON_FLAGS)

So, this changes the dependencies (see below), and adds $(@D) to mkdir
and $(PYTHON_FLAGS) to python... maybe a brief sentence in the commit
message explaining why.

> +
> +indices/u_indices_gen.c: indices/u_indices_gen.py

Shouldn't all of these still depend on $(srcdir)/... ?

> +	$(MKDIR_GEN)
> +	$(PYTHON_GEN) $(srcdir)/indices/u_indices_gen.py > $@
> +
> +indices/u_unfilled_gen.c: indices/u_unfilled_gen.py
> +	$(MKDIR_GEN)
> +	$(PYTHON_GEN) $(srcdir)/indices/u_unfilled_gen.py > $@
> +
> +util/u_format_table.c: util/u_format_table.py \
> +                       util/u_format_pack.py \
> +                       util/u_format_parse.py \
> +                       util/u_format.csv
> +	$(MKDIR_GEN)
> +	$(PYTHON_GEN) $(srcdir)/util/u_format_table.py $(srcdir)/util/u_format.csv > $@
>  
>  noinst_LTLIBRARIES += libgalliumvl_stub.la
>  libgalliumvl_stub_la_SOURCES = \
>