[Mesa-dev] [PATCH v2] isl: remove ffs function that conflicts with system headers

Emil Velikov emil.l.velikov at gmail.com
Mon Apr 25 14:14:57 UTC 2016


On 23 April 2016 at 15:36, Jason Ekstrand <jason at jlekstrand.net> wrote:
> Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
>
And pushed. Thanks Jason.

> In general, we should be using mesa compat headers for this sort of thing
> rather than hand-rolling it.
>
Fully agree with you here. Since ffs is c99 and all targets that mesa
support have it, we don't need one here.
.Iirc the GNU one ffsll was another thing.

Fwiw we have an implementation in src/mesa/main/imports.* that we can nuke.

Jonathan can you do the honours ? Feel free to send over a patch that
drops the __builtin_bswap32 workaround and inlines it.

Thanks
Emil


More information about the mesa-dev mailing list