[Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

[Kenneth Graunke]

On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote:
> On 17/12/16 03:35, Kenneth Graunke wrote:
> > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
> > arb_program_interface_query/arb_program_interface_query-resource-query,
> 
> Somewhat offtopic: FWIW, piglit tests for arb_program_interface_query
> doesn't tests too much the REFERENCED_BY_XXX property (see below). I
> have a wip piglit tests locally that still fails. Mentioning this
> because ...
> 
> > and GL45-CTS.program_interface_query.separate-programs-{tess-control,
> > tess-eval,geometry}.  Only one dEQP program interface failure remains.
> 
> ... as far as I see, just one CTS program interface query keeps failing
> after your patch, and it is caused by some issues with
> REFERENCED_BY_XXX. In any case, about this, now Im somewhat more
> optimistic, after realizing (while testing your patch) that Ian Romanick
> fixed GL45-CTS.geometry_shader.program_resource.program_resource, and
> cleaned up referenced_by on the patch "linker: Accurately track
> gl_uniform_block::stageref" (commit 084105). Will take a look to that
> next Monday.

Is the one remaining failure

    GL45-CTS.program_interface_query.uniform-block-types

...?  I believe that one's fixed by Ian's series:

https://lists.freedesktop.org/archives/mesa-dev/2016-December/138359.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161217/d371afc4/attachment.sig>