[Mesa-dev] [PATCH 03/11] i965/meta: Use _mesa_CreateRenderbuffers instead of _mesa_GenRenderbuffers and _mesa_BindRenderbuffer

Ian Romanick idr at freedesktop.org
Fri Feb 5 21:04:15 UTC 2016


From: Ian Romanick <ian.d.romanick at intel.com>

This has the advantage that it does not pollute the global binding
state.  It also enables later patches that will stop calling
_mesa_GenRenderbuffers / _mesa_CreateRenderbuffers which pollute the
renderbuffer namespace.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 src/mesa/drivers/dri/i965/brw_meta_updownsample.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_meta_updownsample.c b/src/mesa/drivers/dri/i965/brw_meta_updownsample.c
index f39d50a..563160e 100644
--- a/src/mesa/drivers/dri/i965/brw_meta_updownsample.c
+++ b/src/mesa/drivers/dri/i965/brw_meta_updownsample.c
@@ -55,13 +55,12 @@ brw_get_rb_for_slice(struct brw_context *brw,
    struct gl_renderbuffer *rb;
    struct intel_renderbuffer *irb;
 
-   /* This turns the GenRenderbuffers name into an actual struct
+   /* This turns the CreateRenderbuffers name into an actual struct
     * intel_renderbuffer.
     */
-   _mesa_GenRenderbuffers(1, &rbo);
-   _mesa_BindRenderbuffer(GL_RENDERBUFFER, rbo);
+   _mesa_CreateRenderbuffers(1, &rbo);
 
-   rb = ctx->CurrentRenderbuffer;
+   rb = _mesa_lookup_renderbuffer(ctx, rbo);
    irb = intel_renderbuffer(rb);
 
    rb->Format = mt->format;
-- 
2.5.0



More information about the mesa-dev mailing list