[Mesa-dev] [PATCH] glsl: replace _strtoui64() with strtoull() for MSVC

Jose Fonseca jfonseca at vmware.com
Fri Feb 12 12:18:17 UTC 2016


On 11/02/16 23:08, Timothy Arceri wrote:
> Now that MSVC 2013 is required we can remove this.
> ---
>   src/compiler/glsl/glsl_lexer.ll | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll
> index e59f93e..9704fc7 100644
> --- a/src/compiler/glsl/glsl_lexer.ll
> +++ b/src/compiler/glsl/glsl_lexer.ll
> @@ -113,11 +113,7 @@ literal_integer(char *text, int len, struct _mesa_glsl_parse_state *state,
>      if (base == 16)
>         digits += 2;
>
> -#ifdef _MSC_VER
> -   unsigned __int64 value = _strtoui64(digits, NULL, base);
> -#else
>      unsigned long long value = strtoull(digits, NULL, base);
> -#endif
>
>      lval->n = (int)value;
>

Looks good.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


More information about the mesa-dev mailing list