[Mesa-dev] [PATCH] i965: fix MAX_COMPUTE_SHARED_SIZE constant value

Ilia Mirkin imirkin at alum.mit.edu
Sat Feb 13 21:55:32 UTC 2016


On Sat, Feb 13, 2016 at 4:49 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> MAX_COMPUTE_SHARED_SIZE should be set to 32768. This fixes a regression
> introduced in be27f77 (mesa: do not use a constant for
> MAX_COMPUTE_SHARED_SIZE).
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> Cc: Mark Janes <mark.a.janes at intel.com>

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Please wait until a positive test result, or a positive review from
the intel team though.

> ---
>
> This patch is untested because I don't have any Intel GPUs.
>
>  src/mesa/drivers/dri/i965/brw_context.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
> index a5f7a2e..972b62e 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -710,6 +710,7 @@ brw_initialize_cs_context_constants(struct brw_context *brw, unsigned max_thread
>     ctx->Const.MaxComputeWorkGroupSize[1] = max_invocations;
>     ctx->Const.MaxComputeWorkGroupSize[2] = max_invocations;
>     ctx->Const.MaxComputeWorkGroupInvocations = max_invocations;
> +   ctx->Const.MaxComputeSharedMemorySize = 32768;
>  }
>
>  /**
> --
> 2.6.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list