[Mesa-dev] [PATCH] st/mesa: empty buffer binding if the buffer's not really there

Samuel Pitoiset samuel.pitoiset at gmail.com
Sun Feb 14 00:47:45 UTC 2016


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 02/14/2016 01:25 AM, Ilia Mirkin wrote:
> This can happen with 0-sized buffers.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   src/mesa/state_tracker/st_atom_atomicbuf.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_atomicbuf.c b/src/mesa/state_tracker/st_atom_atomicbuf.c
> index d83c396..a27dbe0 100644
> --- a/src/mesa/state_tracker/st_atom_atomicbuf.c
> +++ b/src/mesa/state_tracker/st_atom_atomicbuf.c
> @@ -58,9 +58,11 @@ st_bind_atomics(struct st_context *st,
>            st_buffer_object(binding->BufferObject);
>         struct pipe_shader_buffer sb = { 0 };
>
> -      sb.buffer = st_obj->buffer;
> -      sb.buffer_offset = binding->Offset;
> -      sb.buffer_size = st_obj->buffer->width0 - binding->Offset;
> +      if (st_obj && st_obj->buffer) {
> +         sb.buffer = st_obj->buffer;
> +         sb.buffer_offset = binding->Offset;
> +         sb.buffer_size = st_obj->buffer->width0 - binding->Offset;
> +      }
>
>         st->pipe->set_shader_buffers(st->pipe, shader_type,
>                                      atomic->Binding, 1, &sb);
>


More information about the mesa-dev mailing list