[Mesa-dev] [PATCH 24/25] gallium/radeon: remove unused radeon_shader_binary_free_* functions

[Nicolai Hähnle]

Patches 22-24 are also

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

Very nice series overall!

On 15.02.2016 18:59, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>   src/gallium/drivers/radeon/radeon_elf_util.c | 19 -------------------
>   src/gallium/drivers/radeon/radeon_elf_util.h | 14 --------------
>   2 files changed, 33 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/radeon_elf_util.c b/src/gallium/drivers/radeon/radeon_elf_util.c
> index 70a2c4d..8aaa85d 100644
> --- a/src/gallium/drivers/radeon/radeon_elf_util.c
> +++ b/src/gallium/drivers/radeon/radeon_elf_util.c
> @@ -195,22 +195,3 @@ const unsigned char *radeon_shader_binary_config_start(
>   	}
>   	return binary->config;
>   }
> -
> -void radeon_shader_binary_free_relocs(struct radeon_shader_reloc *relocs,
> -					unsigned reloc_count)
> -{
> -	FREE(relocs);
> -}
> -
> -void radeon_shader_binary_free_members(struct radeon_shader_binary *binary,
> -					unsigned free_relocs)
> -{
> -	FREE(binary->code);
> -	FREE(binary->config);
> -	FREE(binary->rodata);
> -
> -	if (free_relocs) {
> -		radeon_shader_binary_free_relocs(binary->relocs,
> -						binary->reloc_count);
> -	}
> -}
> diff --git a/src/gallium/drivers/radeon/radeon_elf_util.h b/src/gallium/drivers/radeon/radeon_elf_util.h
> index ea4ab2f..c2af9e0 100644
> --- a/src/gallium/drivers/radeon/radeon_elf_util.h
> +++ b/src/gallium/drivers/radeon/radeon_elf_util.h
> @@ -47,18 +47,4 @@ const unsigned char *radeon_shader_binary_config_start(
>   	const struct radeon_shader_binary *binary,
>   	uint64_t symbol_offset);
>
> -/**
> - * Free all memory allocated for members of \p binary.  This function does
> - * not free \p binary.
> - *
> - * @param free_relocs If false, reolc information will not be freed.
> - */
> -void radeon_shader_binary_free_members(struct radeon_shader_binary *binary,
> -	unsigned free_relocs);
> -
> -/**
> - * Free \p relocs and all member data.
> - */
> -void radeon_shader_binary_free_relocs(struct radeon_shader_reloc *relocs,
> -					unsigned reloc_count);
>   #endif /* RADEON_ELF_UTIL_H */
>