[Mesa-dev] [PATCH v2 1/5] egl: Add EGL_FRAMEBUFFER_TARGET_ANDROID attribute

[Emil Velikov]

Hi Rob,

On 2 February 2016 at 20:23, Rob Herring <robh at kernel.org> wrote:
> This is used by Android to select an eglconfig compatible with HWComposer.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
> v2:
> - Also add reporting the extension string
>
>  src/egl/main/eglapi.c     | 1 +
>  src/egl/main/eglconfig.c  | 5 ++++-
>  src/egl/main/eglconfig.h  | 2 ++
>  src/egl/main/egldisplay.h | 1 +
>  4 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
> index 323634e..4619855 100644
> --- a/src/egl/main/eglapi.c
> +++ b/src/egl/main/eglapi.c
> @@ -381,6 +381,7 @@ _eglCreateExtensionsString(_EGLDisplay *dpy)
>     char *exts = dpy->ExtensionsString;
>
>     /* Please keep these sorted alphabetically. */
> +   _EGL_CHECK_EXTENSION(ANDROID_framebuffer_target);
Based off a quick look at the spec, it seems that we're sort of lucky
that things work as is ?
I'm wondering about a brief comment would be best suited to describe
the current situation.

If you can think of something let me know and I'll amend and push the
lot (same goes for ANDROID_recordable and 5/5 which enables both).

-Emil