[Mesa-dev] [PATCH] i965: Fix isoline reads in scalar TES.

Iago Toral itoral at igalia.com
Wed Jun 1 10:07:54 UTC 2016


Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Tue, 2016-05-31 at 22:45 -0700, Kenneth Graunke wrote:
> Isolines aren't reversed.  commit 5b2d8c2273c6f fixed this for the vec4
> TES backend, but not the scalar one.
> 
> Found while debugging GL45-CTS.tessellation_shader.
> tessellation_control_to_tessellation_evaluation.gl_tessLevel.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 58191fc..6b832e0 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -2746,7 +2746,7 @@ fs_visitor::nir_emit_tes_intrinsic(const fs_builder &bld,
>           break;
>        case BRW_TESS_DOMAIN_ISOLINE:
>           for (unsigned i = 0; i < 2; i++)
> -            bld.MOV(offset(dest, bld, i), component(fs_reg(ATTR, 0), 7 - i));
> +            bld.MOV(offset(dest, bld, i), component(fs_reg(ATTR, 0), 6 + i));
>           break;
>        }
>        break;




More information about the mesa-dev mailing list