[Mesa-dev] Split gl_shader in two and clean-ups

[Iago Toral]

On Tue, 2016-06-28 at 11:52 +1000, Timothy Arceri wrote:
> There are two distinctly different uses of this struct. The first
> is to store GL shader objects. The second is to store information
> about a shader stage thats been linked.
> 
> The only place the new structs overlap is the shader layout fields and
> I intend to split that out into a third struct once this series lands.
> 
> Having two well defined structs helps code readability and allows the removal
> of some unreachable code paths that were the result of confusion between
> the two uses.

I think it is a good idea, thanks!

I dropped a comment in patch 4, with that fixed patches 1-4 are:
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

I'll try to review the last 3 patches tomorrow.

Iago

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev