[Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

Varad Gautam varadgautam at gmail.com
Sun Mar 13 21:09:31 UTC 2016


- Do not reorder instructions reading packed sources (fixes piglit
regressions with draw-vertices and draw-vertices-user).
---
Eric, Rhys, with this bit we should be good to go.

 src/gallium/drivers/vc4/vc4_opt_vpm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/vc4/vc4_opt_vpm.c b/src/gallium/drivers/vc4/vc4_opt_vpm.c
index a4ee6af..d15b0c1 100644
--- a/src/gallium/drivers/vc4/vc4_opt_vpm.c
+++ b/src/gallium/drivers/vc4/vc4_opt_vpm.c
@@ -77,7 +77,8 @@ qir_opt_vpm(struct vc4_compile *c)
                         continue;
 
                 for (int j = 0; j < qir_get_op_nsrc(inst->op); j++) {
-                        if (inst->src[j].file != QFILE_TEMP)
+                        if (inst->src[j].file != QFILE_TEMP ||
+                            inst->src[j].pack)
                                 continue;
 
                         uint32_t temp = inst->src[j].index;
-- 
2.6.2



More information about the mesa-dev mailing list