[Mesa-dev] [PATCH 07/10] i965: Assert that an instruction is not inserted around itself.

Francisco Jerez currojerez at riseup.net
Mon Mar 14 23:51:26 UTC 2016


Matt Turner <mattst88 at gmail.com> writes:

> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index dfe6afc..d007ed0 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -948,6 +948,8 @@ adjust_later_block_ips(bblock_t *start_block, int ip_adjustment)
>  void
>  backend_instruction::insert_after(bblock_t *block, backend_instruction *inst)
>  {
> +   assert(this != inst);
> +
>     if (!this->is_head_sentinel())
>        assert(inst_is_in_block(block, this) || !"Instruction not in block");
>  
> @@ -961,6 +963,8 @@ backend_instruction::insert_after(bblock_t *block, backend_instruction *inst)
>  void
>  backend_instruction::insert_before(bblock_t *block, backend_instruction *inst)
>  {
> +   assert(this != inst);
> +
>     if (!this->is_tail_sentinel())
>        assert(inst_is_in_block(block, this) || !"Instruction not in block");
>  

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> -- 
> 2.4.10
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160314/4fa62f9b/attachment.sig>


More information about the mesa-dev mailing list