[Mesa-dev] [PATCH 3/8] tgsi: introduce NonHelperMask

[Brian Paul]

On 03/21/2016 04:02 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This is a mask of which of the current 2x2 grid are non-helper
> invocations. This allows us to mask off the helper invocations
> later for the image operations.

Can you elaborate on what a helper invocation is somewhere in the comments?


>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 ++
>   src/gallium/auxiliary/tgsi/tgsi_exec.h | 2 ++
>   2 files changed, 4 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> index a44a05c..fa1c916 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> @@ -5199,6 +5199,8 @@ tgsi_exec_machine_run( struct tgsi_exec_machine *mach )
>         default_mask = 0x1;
>      }
>
> +   if (mach->NonHelperMask == 0)
> +      mach->NonHelperMask = default_mask;
>      mach->CondMask = default_mask;
>      mach->LoopMask = default_mask;
>      mach->ContMask = default_mask;
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.h b/src/gallium/auxiliary/tgsi/tgsi_exec.h
> index 011c9c3..05ae388 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_exec.h
> +++ b/src/gallium/auxiliary/tgsi/tgsi_exec.h
> @@ -317,6 +317,8 @@ struct tgsi_exec_machine
>      struct tgsi_exec_vector       QuadPos;
>      float                         Face;    /**< +1 if front facing, -1 if back facing */
>      bool                          flatshade_color;
> +
> +   uint NonHelperMask;  /**< non-helpers */
>      /* Conditional execution masks */
>      uint CondMask;  /**< For IF/ELSE/ENDIF */
>      uint LoopMask;  /**< For BGNLOOP/ENDLOOP */
>