[Mesa-dev] [Bug 96235] st_nir.h:34: error: redefinition of typedef ‘nir_shader’

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 27 09:55:34 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=96235

--- Comment #1 from Emil Velikov <emil.l.velikov at gmail.com> ---
Using the forward declaration allows us to avoid including the nir.h header,
thus keeping headers include chain shorter and less things get rebuild as a
result.

On the other hand, typedef redefinition is a C11 feature (iirc) which we cannot
enforce atm. There was a lengthy discussion about killing off the typedefs in
NIR, as they made sense in the C++ GLSL but not the C based NIR.

Don't recall the conclusion of the thread, but fwiw I'm for killing the
typedefs thus being able to build mesa with GCC 4.x series and (in due time)
killing off the unneeded includes of nir*.h and replacing them with fwd
declarations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160527/743eeca9/attachment.html>


More information about the mesa-dev mailing list