[Mesa-dev] [st/omx/dec/h264] Handing negative POC

Namburu, Chandu-babu chandu at amd.com
Wed Nov 30 06:02:42 UTC 2016


Hi Emil,

Thank you for the comments. Please find my response inlined in the below mail.

Regards,
Chandu
-----Original Message-----
From: Emil Velikov [mailto:emil.l.velikov at gmail.com] 
Sent: Tuesday, November 29, 2016 3:09 AM
To: Christian König <deathsimple at vodafone.de>
Cc: Namburu, Chandu-babu <chandu at amd.com>; mesa-dev at lists.freedesktop.org
Subject: Re: [Mesa-dev] [st/omx/dec/h264] Handing negative POC

Hi all,

On 24 November 2016 at 10:22, Christian König <deathsimple at vodafone.de> wrote:
> Hi,
>
> patch is Reviewed-by: Christian König <christian.koenig at amd.com>.
>
Shouldn't we also change the h264.pic_order_cnt_[lm]sb also to signed ?
[NCB] Yes, These variables also need to singed. I will change them and will share the changes shortly.

How about field_order_cnt and field_order_cnt_list ?
We seems to be having an odd mix of signed and unsigned for the latter two.
[NCB] Though in pipe structure it is declared as unsinged int type, it is read as signed int in radeon driver(src/gallium/drivers/radeon/radeon_uvd.h). field_order_cnt_list should be changed to singed int in pipe structures also. Will do the changes accordingly. 

Thanks
Emil
P.S. Chandu-babu, please send future patches inline [1].
[1] http://mesa3d.org/devinfo.html#submitting


More information about the mesa-dev mailing list